Bug 102255

Summary: IndexedDB: Remove magic numbers in record comparator, handle missing case
Product: WebKit Reporter: Joshua Bell <jsbell>
Component: New BugsAssignee: Joshua Bell <jsbell>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, dgrogan, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 102243    
Attachments:
Description Flags
Patch none

Joshua Bell
Reported 2012-11-14 11:13:27 PST
IndexedDB: Remove magic numbers in record comparator, handle missing case
Attachments
Patch (7.21 KB, patch)
2012-11-14 11:36 PST, Joshua Bell 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joshua Bell
Comment 1 2012-11-14 11:36:54 PST
Created attachment 174210 [details] Patch
Joshua Bell
Comment 2 2012-11-14 11:37:32 PST
Comment on attachment 174210 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174210&action=review > Source/WebCore/Modules/indexeddb/IDBLevelDBCoding.cpp:-896 > - // FIXME: Assert not reached here? This will fall through to the ASSERT at the end of the function, as the other cases do.
Joshua Bell
Comment 3 2012-11-14 11:38:07 PST
alecflett@, dgrogan@ - please take a look?
Alec Flett
Comment 4 2012-11-14 14:02:43 PST
Comment on attachment 174210 [details] Patch lgtm, wondering if this is worth merging into M23/M24?
Joshua Bell
Comment 5 2012-11-14 14:05:31 PST
tony@ - r?
WebKit Review Bot
Comment 6 2012-11-14 15:29:27 PST
Comment on attachment 174210 [details] Patch Clearing flags on attachment: 174210 Committed r134680: <http://trac.webkit.org/changeset/134680>
WebKit Review Bot
Comment 7 2012-11-14 15:29:30 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.