Bug 102245

Summary: Running TestWebKitAPI and webkit_unit_tests for Chromium Android should defer to the Chromium-sided test runner
Product: WebKit Reporter: Peter Beverloo <peter>
Component: Tools / TestsAssignee: Peter Beverloo <peter>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 100100    
Attachments:
Description Flags
Patch none

Peter Beverloo
Reported 2012-11-14 09:56:22 PST
Duplicating most of the logic for running arbitrary test-suites is not worth the effort, especially given that Chromium already has an excellent testing framework. This change is dependent on the Chromium-side change which prepares it for WebKit usage, but changes there (in the argument usage) should be minimal. https://codereview.chromium.org/11312239/ Patch upcoming..
Attachments
Patch (2.95 KB, patch)
2012-11-14 10:19 PST, Peter Beverloo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Peter Beverloo
Comment 1 2012-11-14 10:19:08 PST
Created attachment 174193 [details] Patch
Tony Chang
Comment 2 2012-11-14 11:21:00 PST
Comment on attachment 174193 [details] Patch Do we need to wait for the chromium side to land and roll Source/WebKit/chromium/DEPS first?
Peter Beverloo
Comment 3 2012-11-14 11:36:59 PST
Comment on attachment 174193 [details] Patch It doesn't really matter, it's broken already. I'll pull in DEPS later in the week. Thanks for the review!
Peter Beverloo
Comment 4 2012-11-16 03:23:49 PST
Committed r134924: <http://trac.webkit.org/changeset/134924>
Peter Beverloo
Comment 5 2012-11-16 03:32:52 PST
Comment on attachment 174193 [details] Patch I rolled DEPS earlier today and landed this manually (as it's Android only and all the try-bots are green). Thanks again!
Note You need to log in before you can comment on or make changes to this bug.