Summary: | Web Inspector: [Timeline] "Show CPU activity on the ruler" settings checkbox does not take effect until Inspector restart | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexander Pavlov (apavlov) <apavlov> | ||||||||
Component: | Web Inspector (Deprecated) | Assignee: | Eugene Klyuchnikov <eustas> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | apavlov, caseq, eustas, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, yurys | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Alexander Pavlov (apavlov)
2012-11-14 04:13:32 PST
Created attachment 175590 [details]
Patch
Comment on attachment 175590 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175590&action=review > Source/WebCore/inspector/front-end/TimelinePanel.js:138 > + this._mainThreadMonitoringEnabled = WebInspector.settings.showCpuOnTimelineRuler.get() && Capabilities.timelineCanMonitorMainThread; I would check for capability first. > Source/WebCore/inspector/front-end/TimelinePanel.js:160 > + var mainThreadMonitoringEnabled = WebInspector.settings.showCpuOnTimelineRuler.get() && Capabilities.timelineCanMonitorMainThread; I don't think you need a capability check here. Comment on attachment 175590 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175590&action=review >> Source/WebCore/inspector/front-end/TimelinePanel.js:138 >> + this._mainThreadMonitoringEnabled = WebInspector.settings.showCpuOnTimelineRuler.get() && Capabilities.timelineCanMonitorMainThread; > > I would check for capability first. Done. >> Source/WebCore/inspector/front-end/TimelinePanel.js:160 >> + var mainThreadMonitoringEnabled = WebInspector.settings.showCpuOnTimelineRuler.get() && Capabilities.timelineCanMonitorMainThread; > > I don't think you need a capability check here. Done Created attachment 175746 [details]
Patch
Comment on attachment 175746 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175746&action=review > Source/WebCore/inspector/front-end/TimelinePanel.js:159 > + _showCpuOnTimelineRulerChanged: function() { { on the next line Comment on attachment 175746 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175746&action=review >> Source/WebCore/inspector/front-end/TimelinePanel.js:159 >> + _showCpuOnTimelineRulerChanged: function() { > > { on the next line fixed Created attachment 175776 [details]
Patch
Committed r135959: <http://trac.webkit.org/changeset/135959> |