Bug 102196

Summary: Support stand-alone month names in calendar picker
Product: WebKit Reporter: Kent Tamura <tkent>
Component: FormsAssignee: Kent Tamura <tkent>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, haraken, morrita, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 102181    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Kent Tamura
Reported 2012-11-14 01:24:08 PST
Support stand-alone month names in calendar picker
Attachments
Patch (65.24 KB, patch)
2012-11-14 01:35 PST, Kent Tamura 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2012-11-14 01:35:17 PST
Created attachment 174105 [details] Patch
Kentaro Hara
Comment 2 2012-11-14 01:41:40 PST
Comment on attachment 174105 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174105&action=review > Source/WebCore/ChangeLog:20 > + Calls pagePopupController.formatMonth except Japanese locale. Wny do you need to handle Japanese exceptionally? > Source/WebCore/page/PagePopupController.cpp:70 > + date.setMonthsSinceEpoch((year - 1970) * 12.0 + zeroBaseMonth); Nit: 12.0 => 12 ? > Source/WebCore/page/PagePopupController.idl:36 > + [Conditional=CALENDAR_PICKER] DOMString formatMonth(in long year, in long zeroBaseMonth); You're using 'long' not 'unsinged long', is it intended?
Kent Tamura
Comment 3 2012-11-14 01:58:15 PST
Comment on attachment 174105 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174105&action=review >> Source/WebCore/ChangeLog:20 >> + Calls pagePopupController.formatMonth except Japanese locale. > > Wny do you need to handle Japanese exceptionally? We need to add imperial era like "2012年(平成24年) 11月" in Japanese locale, but Locale::formatDateTime doesn't support such form. >> Source/WebCore/page/PagePopupController.idl:36 >> + [Conditional=CALENDAR_PICKER] DOMString formatMonth(in long year, in long zeroBaseMonth); > > You're using 'long' not 'unsinged long', is it intended? It doesn't matter. Both of year and zeroBaseMonth should not be negative.
Kentaro Hara
Comment 4 2012-11-14 02:31:18 PST
Comment on attachment 174105 [details] Patch ok
WebKit Review Bot
Comment 5 2012-11-15 01:48:20 PST
Comment on attachment 174105 [details] Patch Clearing flags on attachment: 174105 Committed r134753: <http://trac.webkit.org/changeset/134753>
WebKit Review Bot
Comment 6 2012-11-15 01:48:25 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.