Bug 102152

Summary: PDFPlugin should support downloading PDFs
Product: WebKit Reporter: Tim Horton <thorton>
Component: PDFAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, mitz, simon.fraser, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch ap: review+

Tim Horton
Reported 2012-11-13 16:36:26 PST
The HUD button to download a PDF is not currently implemented. I have a patch. <rdar://problem/12555313>
Attachments
patch (7.22 KB, patch)
2012-11-13 17:09 PST, Tim Horton 		ap: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2012-11-13 17:09:16 PST
Created attachment 174032 [details] patch
WebKit Review Bot
Comment 2 2012-11-13 17:11:53 PST
Attachment 174032 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/UIProcess/WebPageProxy.h:724: The parameter name "data" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alexey Proskuryakov
Comment 3 2012-11-13 19:04:15 PST
Comment on attachment 174032 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=174032&action=review > Source/WebKit2/UIProcess/WebPageProxy.cpp:4102 > + if (mimeType != "application/pdf") > + return; I'm not sure about the value of this check (and the argument, which is just hardcoded on the other side anyway).
Tim Horton
Comment 4 2012-11-14 12:30:03 PST
Thanks, Alexey! http://trac.webkit.org/changeset/134647
Note You need to log in before you can comment on or make changes to this bug.