Bug 102088

Summary: [BlackBerry] FCC doesn't work in textarea
Product: WebKit Reporter: Rob Buis <rwlbuis>
Component: WebKit BlackBerryAssignee: Rob Buis <rwlbuis>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, mifenton, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch tonikitoo: review+

Rob Buis
Reported 2012-11-13 08:04:34 PST
SSIA
Attachments
Patch (1.84 KB, patch)
2012-11-13 08:07 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (2.02 KB, patch)
2012-11-13 13:29 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (1.79 KB, patch)
2012-11-14 13:38 PST, Rob Buis 		tonikitoo: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2012-11-13 08:07:30 PST
Created attachment 173894 [details] Patch
Yong Li
Comment 2 2012-11-13 08:13:21 PST
Comment on attachment 173894 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173894&action=review > Source/WebKit/blackberry/WebKitSupport/FatFingers.cpp:95 > + || element->isContentEditable() && (element->shadowPseudoId() != "-webkit-search-cancel-button" || !element->isInShadowTree()); So || element->shadowPseudoId() == "-webkit-search-cancel-button" is no longer clickable? Nit: One more pair of braces would be nice.
Antonio Gomes
Comment 3 2012-11-13 08:32:05 PST
Comment on attachment 173894 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173894&action=review To me the proper solution is: use the respondToMouseXXXEvent set of new functions in WebCore. >> Source/WebKit/blackberry/WebKitSupport/FatFingers.cpp:95 >> + || element->isContentEditable() && (element->shadowPseudoId() != "-webkit-search-cancel-button" || !element->isInShadowTree()); > > So || element->shadowPseudoId() == "-webkit-search-cancel-button" is no longer clickable? > > Nit: One more pair of braces would be nice. This is getting too tricky.
Rob Buis
Comment 4 2012-11-13 13:29:54 PST
Created attachment 173969 [details] Patch
Rob Buis
Comment 5 2012-11-14 13:38:13 PST
Created attachment 174244 [details] Patch
Rob Buis
Comment 6 2012-11-16 12:06:47 PST
Committed r134980: <http://trac.webkit.org/changeset/134980>
Note You need to log in before you can comment on or make changes to this bug.