Bug 102078
| Summary: | [GTK] Use GResources in AudioBusGtk | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Philippe Normand <pnormand> |
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | berto, mrobinson |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Philippe Normand
It'd be nice to simplify AudioBusGtk to use GResources, getting rid of the env var for uninstalled use-case too.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Alberto Garcia
Looking into this.
Alberto Garcia
If I understand correctly the only use csae is to make audio resources
easy to load when we run things from the compilation directory, is
that right?
If that's the case maybe we can come up with a different solution that
doesn't involve increasing the size of the library that much
(Composite.wav is 240K)
Philippe Normand
(In reply to comment #2)
> If I understand correctly the only use csae is to make audio resources
> easy to load when we run things from the compilation directory, is
> that right?
>
As discussed on Jabber, yes.
> If that's the case maybe we can come up with a different solution that
> doesn't involve increasing the size of the library that much
> (Composite.wav is 240K)
Let's close this then
Alberto Garcia
> (In reply to comment #2)
> > If I understand correctly the only use csae is to make audio resources
> > easy to load when we run things from the compilation directory, is
> > that right?
>
> As discussed on Jabber, yes.
Then one possibility could be to assume that things are being run from
inside the WebKit directory and if the files are not available in the
system path we can try to find them in
Source/WebCore/platform/audio/resources
../Source/WebCore/platform/audio/resources
../../Source/WebCore/platform/audio/resources
etc.
That should be easy to do, but I'm not sure if you like the idea.