Summary: | Split NetworkRequest up into a request class and a loading class | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||
Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ap, levin+threading, sam, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Mac | ||||||
OS: | All | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 98537 | ||||||
Attachments: |
|
Description
Brady Eidson
2012-11-12 22:46:57 PST
Created attachment 173827 [details]
Patch v1
Attachment 173827 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Source/WebKit2/NetworkProcess/HostRecord.cpp:32: Alphabetical sorting problem. [build/include_order] [4]
Source/WebKit2/NetworkProcess/NetworkResourceLoadScheduler.cpp:8: Alphabetical sorting problem. [build/include_order] [4]
Source/WebKit2/Shared/Network/NetworkResourceLoadParameters.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 3 in 14 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Fixed style errors locally Comment on attachment 173827 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=173827&action=review Great idea! > Source/WebKit2/ChangeLog:10 > + This patch splits it into "NetworkResourceLoadParameters" for all request-related data Can the former keep the NetworkRequest name? (In reply to comment #4) > (From update of attachment 173827 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=173827&action=review > > Great idea! > > > Source/WebKit2/ChangeLog:10 > > + This patch splits it into "NetworkResourceLoadParameters" for all request-related data > > Can the former keep the NetworkRequest name? I started out keeping that name, but the naming started to fall apart as the "request" contained a "request" and it also contained datum not related directly to the request. I also noticed that - from the perspective of WebCore in the WebProcess - this data represents a "ResourceLoader" that has already been created. I'm definitely open to discussion and suggestions on this naming, but I'm going to land as-is since any changes are an easy substitution followup. |