Bug 102040

Summary: [Chromium] Add tests for month suggestion picker
Product: WebKit Reporter: Keishi Hattori <keishi>
Component: FormsAssignee: Keishi Hattori <keishi>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Keishi Hattori
Reported 2012-11-12 20:48:26 PST
Add tests for month suggestion picker
Attachments
Patch (133.34 KB, patch)
2012-11-14 22:06 PST, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
Patch (132.61 KB, patch)
2012-11-14 22:46 PST, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
Patch (135.25 KB, patch)
2012-11-15 04:01 PST, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Keishi Hattori
Comment 1 2012-11-14 22:06:50 PST
Created attachment 174345 [details] Patch
Keishi Hattori
Comment 2 2012-11-14 22:46:27 PST
Created attachment 174352 [details] Patch
Kent Tamura
Comment 3 2012-11-15 01:34:22 PST
Comment on attachment 174352 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174352&action=review > LayoutTests/platform/chromium/TestExpectations:2828 > Maybe you want to add month-suggestion-picker-key-operations.html too because of F4 difference? > LayoutTests/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-key-operations.html:89 > + shouldBe('popupWindow.pagePopupController.toString()', '"[object PagePopupController]"'); nit: shouldBeEqualToString is better because we can avoid nested quotes. > LayoutTests/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-key-operations.html:95 > + shouldBe('highlightedEntry()', '"2012-01"'); ditto.
WebKit Review Bot
Comment 4 2012-11-15 02:41:37 PST
Comment on attachment 174352 [details] Patch Attachment 174352 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14857153 New failing tests: platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-key-operations.html
Keishi Hattori
Comment 5 2012-11-15 04:01:42 PST
Created attachment 174400 [details] Patch
WebKit Review Bot
Comment 6 2012-11-15 04:46:59 PST
Comment on attachment 174400 [details] Patch Clearing flags on attachment: 174400 Committed r134764: <http://trac.webkit.org/changeset/134764>
WebKit Review Bot
Comment 7 2012-11-15 04:47:03 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.