Bug 102026

Summary: Include child layers in the remote layer tree transaction
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch kling: review+

Anders Carlsson
Reported 2012-11-12 17:59:08 PST
Include child layers in the remote layer tree transaction
Attachments
Patch (8.64 KB, patch)
2012-11-12 18:03 PST, Anders Carlsson 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2012-11-12 18:03:49 PST
Created attachment 173778 [details] Patch
WebKit Review Bot
Comment 2 2012-11-12 18:06:20 PST
Attachment 173778 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/WebProcess/WebPage/mac/RemoteGraphicsLayer.h:51: The parameter name "layer" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit2/WebProcess/WebPage/mac/RemoteGraphicsLayer.h:52: The parameter name "layer" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andreas Kling
Comment 3 2012-11-12 18:09:12 PST
Comment on attachment 173778 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173778&action=review > Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.mm:116 > + layerProperties.children.append(childLayer->layerID()); You could prematurely micro-optimize with uncheckedAppend() here!
Anders Carlsson
Comment 4 2012-11-12 18:10:42 PST
Committed r134336: <http://trac.webkit.org/changeset/134336>
Note You need to log in before you can comment on or make changes to this bug.