Summary: | Please reinstate --pixel | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
Component: | Tools / Tests | Assignee: | Zan Dobersek <zan> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, dpranke, eric, simon.fraser, webkit.review.bot, zan | ||||
Priority: | P2 | Keywords: | NRWT | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Simon Fraser (smfr)
2012-11-12 14:40:27 PST
ORWT supports --pixel-tests, and NRWT supports -p and --pixel-tests; I think the fact that --pixel worked is a side-effect of the way that Perl supports things (unique prefixes for an arg will work), but Python's standard option parsing doesn't do that. We can add in a --pixel synonym for -p or --pixel-tests, but you're the first person that's complained about this. Are you sure you can't rewire your brain to support the shorter -p ? mitz has also complained about this. I guess i can try getting used to -p. to be clear: I'm happy to add this (it's one line or less) if there's really a need, but it seems kinda silly. The strongest argument I have is that ORWT had this for years, and as a result some people expect it to work. My only hesitation is that since perl supported *any* unique prefix, I'm not sure how many different versions to add. Is "--pixel" enough? Are there other switches that need similar shortcuts? This is the only one I habitually type in and have it not work (though I get confused about --new-baseline vs. --new-baselines). Created attachment 182943 [details]
Patch
Comment on attachment 182943 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182943&action=review > Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:136 > + optparse.make_option("-p", "--pixel", "--pixel-tests", action="store_true", I didn't realize that worked; I always assumed it was one short and one long :) . Comment on attachment 182943 [details] Patch Clearing flags on attachment: 182943 Committed r139912: <http://trac.webkit.org/changeset/139912> All reviewed patches have been landed. Closing bug. |