Bug 101979

Summary: nrwt: remove a bunch of broken chromium-specific flags
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: New BugsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, adamk, ojan, tony
Priority: P2 Keywords: NRWT
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch tony: review+

Dirk Pranke
Reported 2012-11-12 13:44:50 PST
nrwt: remove a bunch of broken chromium-specific flags
Attachments
Patch (5.22 KB, patch)
2012-11-12 13:46 PST, Dirk Pranke 		tony: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2012-11-12 13:46:28 PST
Created attachment 173712 [details] Patch
Tony Chang
Comment 2 2012-11-12 13:49:15 PST
Comment on attachment 173712 [details] Patch Ok, but I thought there was a GPU test lab with real hardware that ran with some of the accelerated code paths.
Dirk Pranke
Comment 3 2012-11-12 13:51:03 PST
There might be, but if there is, it's using --additional-drt-flag, because the --accelerated-* flags weren't being honored. So, worst case, a bot breaks because of an unrecognized flag, and we notice the real problem.
Dirk Pranke
Comment 4 2012-11-12 14:34:08 PST
Committed r134308: <http://trac.webkit.org/changeset/134308>
Ojan Vafai
Comment 5 2012-11-12 15:03:55 PST
Comment on attachment 173712 [details] Patch nice!
Note You need to log in before you can comment on or make changes to this bug.