Bug 101959 – IndexedDB: Convert some non-simple tests from setVersion to upgradeneeded

• Component: New Bugs
• Status: RESOLVED FIXED

[David Grogan]

IndexedDB: Convert some non-simple tests from setVersion to upgradeneeded

[David Grogan]

Created attachment 173681 [details]
Patch

[David Grogan]

Josh, could you take a look at this?

[Joshua Bell]

Comment on attachment 173681 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173681&action=review

lgtm

> LayoutTests/ChangeLog:33
> +          optional object parameter instead of adding a string of optional

The phrase "adding a string of optional parameters" is confusing (string-as-type, or string-as-series?). I'd just end the sentence after "optional object parameter"

> LayoutTests/storage/indexeddb/resources/create-and-remove-object-store.js:29
> +    debug("Trying create");

Since this function is already changing so much, can you rename "tryOnceMore" since it's no longer a correct description?

> LayoutTests/storage/indexeddb/resources/shared.js:178
>      setDBNameFromPath();

Maybe pass the suffix into setDBNameFromPath() to only log dbname once rather than "dbname = ..." / "overridden dbname = ..."

[David Grogan]

Comment on attachment 173681 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173681&action=review

>> LayoutTests/ChangeLog:33
>> +          optional object parameter instead of adding a string of optional
> 
> The phrase "adding a string of optional parameters" is confusing (string-as-type, or string-as-series?). I'd just end the sentence after "optional object parameter"

Done.

>> LayoutTests/storage/indexeddb/resources/create-and-remove-object-store.js:29
>> +    debug("Trying create");
> 
> Since this function is already changing so much, can you rename "tryOnceMore" since it's no longer a correct description?

Done.

>> LayoutTests/storage/indexeddb/resources/shared.js:178
>>      setDBNameFromPath();
> 
> Maybe pass the suffix into setDBNameFromPath() to only log dbname once rather than "dbname = ..." / "overridden dbname = ..."

Done.

[David Grogan]

Created attachment 173703 [details]
Patch

[David Grogan]

Tony, could you review this?  It's more test conversions.

[David Grogan]

Comment on attachment 173703 [details]
Patch

Thanks for the review.

[WebKit Review Bot]

Comment on attachment 173703 [details]
Patch

Clearing flags on attachment: 173703

Committed r134335: <http://trac.webkit.org/changeset/134335>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.