Bug 101957

Summary: Add the TestRunner public API to the ChromiumPublicApi watchlist, and introduce an entry for ChromiumTestRunner
Product: WebKit Reporter: jochen
Component: New BugsAssignee: jochen
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, dpranke, fishd, jamesr, ojan, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch abarth: review+, abarth: commit-queue-

jochen
Reported 2012-11-12 11:23:59 PST
Add the TestRunner public API to the ChromiumPublicApi watchlist, and introduce an entry for ChromiumTestRunner
Attachments
Patch (2.27 KB, patch)
2012-11-12 11:25 PST, jochen 		abarth: review+
abarth: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
jochen
Comment 1 2012-11-12 11:25:34 PST
Created attachment 173676 [details] Patch
jochen
Comment 2 2012-11-12 11:29:42 PST
Since content_shell links against TestRunner, we should make sure its public API follows similar rules than the rest of our webkit API. Is it ok to just add the TestRunner/public dir to the ChromiumPublicApi list?
Adam Barth
Comment 3 2012-11-12 11:57:17 PST
Comment on attachment 173676 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173676&action=review Yep > Tools/Scripts/webkitpy/common/config/watchlist:302 > + "ChromiumTestRunner": [ "jochen@chromium.org", ], No need for the trailing ,
Adam Barth
Comment 4 2012-11-12 11:57:35 PST
Comment on attachment 173676 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173676&action=review > Tools/Scripts/webkitpy/common/config/watchlist:20 > + r"|Source/Platform/chromium/public/" I think you're missing a , at the end of this line.
jochen
Comment 5 2012-11-12 14:03:51 PST
Comment on attachment 173676 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173676&action=review >> Tools/Scripts/webkitpy/common/config/watchlist:20 >> + r"|Source/Platform/chromium/public/" > > I think you're missing a , at the end of this line. no, see e.g. line 19
Adam Barth
Comment 6 2012-11-12 14:07:49 PST
Comment on attachment 173676 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173676&action=review >>> Tools/Scripts/webkitpy/common/config/watchlist:20 >>> + r"|Source/Platform/chromium/public/" >> >> I think you're missing a , at the end of this line. > > no, see e.g. line 19 Ah, you're right. /me forgets that this isn't really JSON.
jochen
Comment 7 2012-11-13 03:33:04 PST
Committed r134394: <http://trac.webkit.org/changeset/134394>
Note You need to log in before you can comment on or make changes to this bug.