Summary: | Web Inspector: remove total item from NMI snapshot grid | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexei Filippov <alph> | ||||||||
Component: | Web Inspector (Deprecated) | Assignee: | Alexei Filippov <alph> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Alexei Filippov
2012-11-12 04:30:34 PST
Created attachment 173617 [details]
Patch
Comment on attachment 173617 [details]
Patch
I'd leave it when "Show unknown size" option is on. WDYT?
(In reply to comment #2) > (From update of attachment 173617 [details]) > I'd leave it when "Show unknown size" option is on. WDYT? I'm fine with that, but the patch you're talking about has not been approved yet. See https://bugs.webkit.org/show_bug.cgi?id=101601 Comment on attachment 173617 [details]
Patch
As per last comment.
Created attachment 174183 [details]
Patch
Comment on attachment 174183 [details] Patch Rejecting attachment 174183 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ommit-queue/Source/WebKit/chromium/third_party/snappy/src --revision 63 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 50>At revision 63. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/14905115 Created attachment 175448 [details]
Patch
rebaselined Comment on attachment 175448 [details] Patch Clearing flags on attachment: 175448 Committed r135608: <http://trac.webkit.org/changeset/135608> All reviewed patches have been landed. Closing bug. |