Bug 101916

Summary: Refactoring: set read-only values on layout in DateTimeEditElement
Product: WebKit Reporter: Kent Tamura <tkent>
Component: FormsAssignee: Kent Tamura <tkent>
Status: RESOLVED FIXED    
Severity: Normal CC: haraken, mifenton, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 101889    
Attachments:
Description Flags
Patch
none
Patch for landing none

Kent Tamura
Reported 2012-11-12 03:11:08 PST
Refactoring: set read-only values on layout in DateTimeEditElement
Attachments
Patch (26.86 KB, patch)
2012-11-12 03:29 PST, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Patch for landing (26.83 KB, patch)
2012-11-12 06:23 PST, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2012-11-12 03:29:07 PST
Created attachment 173605 [details] Patch
Kentaro Hara
Comment 2 2012-11-12 03:42:05 PST
Comment on attachment 173605 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173605&action=review > Source/WebCore/ChangeLog:5 > + Need the bug URL (OOPS!). Remove this. > Source/WebCore/html/shadow/DateTimeNumericFieldElement.cpp:163 > +void DateTimeNumericFieldElement::setEmptyValue(EventBehavior eventBehavior) I'm a bit confused by this name. What does 'Empty' mean? setDefaultValue() might sound better.
Kent Tamura
Comment 3 2012-11-12 06:21:11 PST
Comment on attachment 173605 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173605&action=review Thank you for the review. >> Source/WebCore/ChangeLog:5 >> + Need the bug URL (OOPS!). > > Remove this. OOPS! >> Source/WebCore/html/shadow/DateTimeNumericFieldElement.cpp:163 >> +void DateTimeNumericFieldElement::setEmptyValue(EventBehavior eventBehavior) > > I'm a bit confused by this name. What does 'Empty' mean? setDefaultValue() might sound better. 'Empty' means really empty. This function is something like input.value = "". In the Forms area, "default" means the initial value (<input value="default">). setEmptyValue actually had a confusing role. This patch makes it clearer.
Kent Tamura
Comment 4 2012-11-12 06:23:32 PST
Created attachment 173636 [details] Patch for landing
WebKit Review Bot
Comment 5 2012-11-12 07:39:04 PST
Comment on attachment 173636 [details] Patch for landing Clearing flags on attachment: 173636 Committed r134239: <http://trac.webkit.org/changeset/134239>
WebKit Review Bot
Comment 6 2012-11-12 07:39:08 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.