Summary: | Refactoring: set read-only values on layout in DateTimeEditElement | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kent Tamura <tkent> | ||||||
Component: | Forms | Assignee: | Kent Tamura <tkent> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | haraken, mifenton, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 101889 | ||||||||
Attachments: |
|
Description
Kent Tamura
2012-11-12 03:11:08 PST
Created attachment 173605 [details]
Patch
Comment on attachment 173605 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173605&action=review > Source/WebCore/ChangeLog:5 > + Need the bug URL (OOPS!). Remove this. > Source/WebCore/html/shadow/DateTimeNumericFieldElement.cpp:163 > +void DateTimeNumericFieldElement::setEmptyValue(EventBehavior eventBehavior) I'm a bit confused by this name. What does 'Empty' mean? setDefaultValue() might sound better. Comment on attachment 173605 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173605&action=review Thank you for the review. >> Source/WebCore/ChangeLog:5 >> + Need the bug URL (OOPS!). > > Remove this. OOPS! >> Source/WebCore/html/shadow/DateTimeNumericFieldElement.cpp:163 >> +void DateTimeNumericFieldElement::setEmptyValue(EventBehavior eventBehavior) > > I'm a bit confused by this name. What does 'Empty' mean? setDefaultValue() might sound better. 'Empty' means really empty. This function is something like input.value = "". In the Forms area, "default" means the initial value (<input value="default">). setEmptyValue actually had a confusing role. This patch makes it clearer. Created attachment 173636 [details]
Patch for landing
Comment on attachment 173636 [details] Patch for landing Clearing flags on attachment: 173636 Committed r134239: <http://trac.webkit.org/changeset/134239> All reviewed patches have been landed. Closing bug. |