Bug 101894

Summary: [BlackBerry] DRT - Update Pixel Dump Support for OpenGL renderer
Product: WebKit Reporter: Xiaobo Wang <xiaobwang>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: mifenton, mxie, rwlbuis, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Attachments:
Description Flags
patch
rwlbuis: review+
patch - updated none

Xiaobo Wang
Reported 2012-11-11 22:34:37 PST
Need to update Pixel Dump Support code for OpenGL render. The current implementation doesn't work and will cause crash when dumping pixel images. RIM PR 241686.
Attachments
patch (4.29 KB, patch)
2012-11-11 22:56 PST, Xiaobo Wang 		rwlbuis: review+
DetailsFormatted DiffDiff
patch - updated (4.30 KB, patch)
2012-11-12 18:28 PST, Xiaobo Wang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Xiaobo Wang
Comment 1 2012-11-11 22:56:34 PST
Created attachment 173565 [details] patch
Rob Buis
Comment 2 2012-11-12 08:04:56 PST
Comment on attachment 173565 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=173565&action=review LGTM. > Tools/ChangeLog:9 > + code path. Please add a PR number if there is one.
Xiaobo Wang
Comment 3 2012-11-12 18:28:12 PST
Created attachment 173784 [details] patch - updated Adding RIM PR number in the ChangeLog.
Xiaobo Wang
Comment 4 2012-11-12 18:30:25 PST
Comment on attachment 173565 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=173565&action=review >> Tools/ChangeLog:9 >> + code path. > > Please add a PR number if there is one. Sure, thanks for pointing it out.
Rob Buis
Comment 5 2012-11-12 19:27:53 PST
Comment on attachment 173784 [details] patch - updated Ok.
WebKit Review Bot
Comment 6 2012-11-12 21:54:17 PST
Comment on attachment 173784 [details] patch - updated Clearing flags on attachment: 173784 Committed r134359: <http://trac.webkit.org/changeset/134359>
WebKit Review Bot
Comment 7 2012-11-12 21:54:20 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.