Summary: | Add support for week/month to Locale::formatDateTime() | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Keishi Hattori <keishi> | ||||||
Component: | Forms | Assignee: | Keishi Hattori <keishi> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | tkent, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Keishi Hattori
2012-11-11 18:27:31 PST
Created attachment 173592 [details]
Patch
Comment on attachment 173592 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173592&action=review > Source/WebCore/ChangeLog:10 > + No new tests. Added Chromium tests LocaleMacTest.formatWeek and LocaleMacTest.formatMonth. nit: "No new tests." is unnecessary. > Source/WebCore/platform/text/PlatformLocale.cpp:102 > case DateTimeFormat::FieldTypeMonth: We need to support FieldTypeMonthStandAlone too. Some locales such as Russian use it. > Source/WebCore/platform/text/PlatformLocale.cpp:360 > - if (date.type() != DateComponents::Time && date.type() != DateComponents::Date) > + if (date.type() != DateComponents::Time && date.type() != DateComponents::Date && date.type() != DateComponents::Week && date.type() != DateComponents::Month) > return String(); nit: if (date.type() == DateComponents::DateTime || date.type() == DateComponents::DateTimeLocal || date.type() == DateComponents::Invalid) is shorter. > Source/WebCore/platform/text/PlatformLocale.cpp:371 > builder.build(formatType == FormatTypeShort ? shortTimeFormat() : timeFormat()); > else if (date.type() == DateComponents::Date) > builder.build(dateFormat()); > + else if (date.type() == DateComponents::Week) > + builder.build(weekFormatInLDML()); > + else if (date.type() == DateComponents::Month) > + builder.build(monthFormat()); nit: It's time to apply switch-case. Created attachment 173613 [details]
Patch
Comment on attachment 173613 [details] Patch Clearing flags on attachment: 173613 Committed r134216: <http://trac.webkit.org/changeset/134216> All reviewed patches have been landed. Closing bug. |