Summary: | REGRESSION(r134144): seems to break win 7 chromium browser test (Requested by hayato on #webkit). | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | WebKit Review Bot <webkit.review.bot> | ||||
Component: | New Bugs | Assignee: | WebKit Review Bot <webkit.review.bot> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, dglazkov, hayato, rbyers | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 100550 | ||||||
Attachments: |
|
Description
WebKit Review Bot
2012-11-11 18:12:33 PST
Created attachment 173531 [details] ROLLOUT of r134144 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. r134144 seems to break Win7 chromium browser tests. The following tests started to fail since http://build.chromium.org/p/chromium.webkit/builders/Win7%20%28dbg%29/builds/8232. - PrerenderClickToPlay - PrerenderNaClPluginDisabled - PrerenderNaClPluginEnabled Build log: http://build.chromium.org/p/chromium.webkit/builders/Win7%20%28dbg%29/builds/8232/steps/browser_tests/logs/PrerenderNaClPluginDisabled PrerenderBrowserTest.PrerenderNaClPluginDisabled: [3960:884:1110/054331:20249600:INFO:CONSOLE(0)] "Only unpacked extensions and apps installed from the Chrome Web Store can load NaCl modules without enabling Native Client in about:flags.", source: (0) [3960:884:1110/054332:20249912:FATAL:webcursor_win.cc(104)] Check failed: false. Backtrace: base::PlatformThread::Sleep [0x6DB70FD1+2233748] base::PlatformThread::Sleep [0x6DA1772E+818417] Check failed in wecursor_win.cc:104. http://code.google.com/searchframe#OAMlx_jo-ck/src/webkit/glue/webcursor_win.cc&exact_package=chromium&q=webcursor_win.cc&type=cs&l=104 r134144 seems to be related. Let me rollout that and watch the result. Comment on attachment 173531 [details] ROLLOUT of r134144 Clearing flags on attachment: 173531 Committed r134183: <http://trac.webkit.org/changeset/134183> All reviewed patches have been landed. Closing bug. Really? I thought that patch just added some tests... (In reply to comment #5) > Really? I thought that patch just added some tests... I am pretty sure the problem is with the builder. For the record this was indeed my fault (one tiny line added to the product itself to support the tests, and I missed adding braces). See bug 100550 for details and improvements to make it harder to hit this specific issue in the future. Sorry for the trouble. |