Bug 10187 – REGRESSION: Mangled focus ring

• Component: Forms
• Status: RESOLVED WORKSFORME

[Alexander Kellett]

Go to above page. Tab to the comment form field. Notice the very strange shape of the focus ring.

[David Kilzer (:ddkilzer)]

Similar to Bug 10049 for NativePopUp?

Created attachment 9892 [details]
Test case reduction

[David Kilzer (:ddkilzer)]

(In reply to comment #1)
> Similar to Bug 10049 for NativePopUp?

Not so much.  Regressions are P1.

[Stephanie Lewis]

radar 4823054

[David Kilzer (:ddkilzer)]

This seems to be fixed in my locally-built debug build of WebKit r18411 with Safari 2.0.4 (419.3) on Mac OS X 10.4.8 (8N1037).

[Adele Peterson]

I also can not reproduce in the latest build.

[Alexander Kellett]

<style>
input:after {
    content: "yay";
}
</style>

<input type="text"/>

[Mark Rowe (bdash)]

With the HTML mentioned in comment 7 I see a focus ring that contains both the text field and the generated content, which is what I would expect.  Firefox doesn't seem to display the generated content, so I can't test its behaviour.  I'm tempted to close this as WFM, but the original report is incredibly unclear as to what the problem is so I can't be sure it's working.

[Alexander Kellett]

why would you expect the focus ring of the text field to also wrap around another element?
while technically i'm sure there are reasons why you would want to assert that the after: is part of the element, does the spec really take precendence over common sense here?
its looks just plain strange.

[Maciej Stachowiak]

It's arguable that this is correct behavior. Yes, it looks weird, but generated content is inherently kind of weird.

[Alexander Kellett]

okay.. disagree entirely but feel free to close.

[Mark Rowe (bdash)]

Common sense would suggest that using :after on an input element is pretty bizarre thing to do, and thus I would expect bizarre results.  If the generated content is considered when constructing the outline of the element then the behaviour would be correct, otherwise it is incorrect.  I cannot recall which the spec calls for.

[Sam Weinig]

I am closing this as WORKSFORME as the original bug has been fixed.  Alex, if you feel the focus ring with the generated content is wrong, would please file a new bug.

[Sam Weinig]

Alex, don't worry about creating a new bug, I opened a new bug (bug 12776) to continue the discussion.