Bug 101842

Summary: Web Inspector: move indentation logic into TextEditorModel
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, dglazkov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
[Patch] rebaselined
none
[Patch] rebaselined vsevik: review+

Pavel Feldman
Reported 2012-11-10 10:08:32 PST
I'd like to move as much headless logic into the TextEditorModel as possible
Attachments
Patch (18.52 KB, patch)
2012-11-10 10:11 PST, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
Patch (21.17 KB, patch)
2012-11-10 11:36 PST, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
[Patch] rebaselined (21.35 KB, patch)
2012-11-10 23:32 PST, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
[Patch] rebaselined (21.35 KB, patch)
2012-11-11 05:59 PST, Pavel Feldman 		vsevik: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2012-11-10 10:11:24 PST
Created attachment 173457 [details] Patch
WebKit Review Bot
Comment 2 2012-11-10 11:04:07 PST
Comment on attachment 173457 [details] Patch Attachment 173457 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14794396 New failing tests: inspector/editor/indentation.html
Pavel Feldman
Comment 3 2012-11-10 11:36:53 PST
Created attachment 173461 [details] Patch
Pavel Feldman
Comment 4 2012-11-10 23:32:41 PST
Created attachment 173489 [details] [Patch] rebaselined
Pavel Feldman
Comment 5 2012-11-11 05:59:41 PST
Created attachment 173502 [details] [Patch] rebaselined
Pavel Feldman
Comment 6 2012-11-13 00:49:17 PST
Committed r134382: <http://trac.webkit.org/changeset/134382>
Note You need to log in before you can comment on or make changes to this bug.