Bug 101833

Summary:

Change build congratulation message in EFL

Product:

WebKit

Reporter:

Kangil Han <kangil.han>

Component:

WebKit EFL

Assignee:

Kangil Han <kangil.han>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dbates, gyuyoung.kim, laszlo.gombos, lucas.de.marchi, ryuan.choi, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Kangil Han

Reported 2012-11-10 00:53:46 PST

Adopt WK2 launcher name.

Attachments
Patch (2.31 KB, patch) 2012-11-10 00:55 PST, Kangil Han	no flags	Details Formatted Diff Diff
Patch (2.41 KB, patch) 2012-11-11 18:34 PST, Kangil Han	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Kangil Han

Comment 1 2012-11-10 00:55:21 PST

Laszlo Gombos

Comment 2 2012-11-11 18:13:42 PST

Comment on attachment 173440 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173440&action=review > Tools/Scripts/build-webkit:457 > + } I do not think we should have an isEFL() test just for this - perhaps you can make this longer unconditionally. > Tools/Scripts/build-webkit:467 > + } Ditto.

Kangil Han

Comment 3 2012-11-11 18:34:14 PST

Kangil Han

Comment 4 2012-11-11 18:35:34 PST

(In reply to comment #2) > (From update of attachment 173440 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=173440&action=review > > > Tools/Scripts/build-webkit:457 > > + } > > I do not think we should have an isEFL() test just for this - perhaps you can make this longer unconditionally. > > > Tools/Scripts/build-webkit:467 > > + } > > Ditto. Done. :)

WebKit Review Bot

Comment 5 2012-11-11 23:24:57 PST

WebKit Review Bot

Comment 6 2012-11-11 23:25:01 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.