Bug 101817

Summary: [Mac] Guard WebCore PageVisibility Symbol Export
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2012-11-09 17:05:23 PST
shell> c++filt __ZN7WebCore4Page18setVisibilityStateENS_19PageVisibilityStateEb WebCore::Page::setVisibilityState(WebCore::PageVisibilityState, bool) shell> ack -C 5 setVisibilityState page/Page.h #if ENABLE(PAGE_VISIBILITY_API) || ENABLE(HIDDEN_PAGE_DOM_TIMER_THROTTLING) void setVisibilityState(PageVisibilityState, bool); #endif This symbol is only used guarded by these ifdefs, so it should only be exported guarded by these ifdefs. Fix to follow.
Attachments
[PATCH] Proposed Fix (1.69 KB, patch)
2012-11-09 17:07 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2012-11-09 17:07:10 PST
Created attachment 173408 [details] [PATCH] Proposed Fix
WebKit Review Bot
Comment 2 2012-11-10 08:11:34 PST
Comment on attachment 173408 [details] [PATCH] Proposed Fix Clearing flags on attachment: 173408 Committed r134158: <http://trac.webkit.org/changeset/134158>
WebKit Review Bot
Comment 3 2012-11-10 08:11:37 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.