| Summary: | MediaStream API: Schedule the RTCDataChannel events to be triggered at idle state | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tommy Widenflycht <tommyw> | ||||||
| Component: | WebCore Misc. | Assignee: | Tommy Widenflycht <tommyw> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | abarth, dglazkov, eric.carlson, feature-media-reviews, fishd, hta, jamesr, tkent+wkapi, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 56459 | ||||||||
| Attachments: |
|
||||||||
|
Description
Tommy Widenflycht
2012-11-09 06:04:15 PST
Created attachment 173290 [details]
Patch
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. Comment on attachment 173290 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173290&action=review > Source/WebCore/Modules/mediastream/RTCDataChannel.cpp:288 > + events.clear(); This line shouldn't be needed. The vector will get cleared naturally as the stack unwinds. Created attachment 173597 [details]
Patch for landing
Comment on attachment 173290 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173290&action=review >> Source/WebCore/Modules/mediastream/RTCDataChannel.cpp:288 >> + events.clear(); > > This line shouldn't be needed. The vector will get cleared naturally as the stack unwinds. Removed. Comment on attachment 173597 [details] Patch for landing Clearing flags on attachment: 173597 Committed r134207: <http://trac.webkit.org/changeset/134207> |