Bug 101729 – Web Inspector: NMI add instrumentation for WebAudo related stuff. It uses about 16Mb for shared data on pages with webaudio. As example Angry Birds app.

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Ilya Tikhonovsky]

EOM

[Ilya Tikhonovsky]

Created attachment 173268 [details]
Patch

[EFL EWS Bot]

Comment on attachment 173268 [details]
Patch

Attachment 173268 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/14770616

[Early Warning System Bot]

Comment on attachment 173268 [details]
Patch

Attachment 173268 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/14683453

[Early Warning System Bot]

Comment on attachment 173268 [details]
Patch

Attachment 173268 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/14788132

[Ilya Tikhonovsky]

Created attachment 173271 [details]
for qt bot

[Build Bot]

Comment on attachment 173271 [details]
for qt bot

Attachment 173271 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/14778396

[Yury Semikhatsky]

Comment on attachment 173268 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173268&action=review

> Source/WebCore/dom/ActiveDOMObject.cpp:98
> +    UNUSED_PARAM(info);

Please remove this.

> Source/WebCore/dom/ContextDestructionObserver.h:43
> +    virtual void reportMemoryUsage(MemoryObjectInfo*) const;

We shouldn't add reportMemoryUsage to abstract interfaces as we don't control their implementations.

> Source/WebCore/dom/WebCoreMemoryInstrumentation.h:48
> +    static MemoryObjectType Audio;

Should go into PlatformMemoryInstrumentation.h

[Yury Semikhatsky]

Except for the comments above the instrumentation looks good. But I'd like someone familiar with web audio code to look at AudioContext::reportMemoryUsage and AutoLocker call in it.

[Ilya Tikhonovsky]

Created attachment 173287 [details]
with fix for mac and win bots.

[Build Bot]

Comment on attachment 173287 [details]
with fix for mac and win bots.

Attachment 173287 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/14785201

[Build Bot]

Comment on attachment 173287 [details]
with fix for mac and win bots.

Attachment 173287 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/14771712

[Ilya Tikhonovsky]

Created attachment 173442 [details]
with fix for mac, gtk and win bots.

[Ilya Tikhonovsky]

Created attachment 173573 [details]
with additional instrumentation for fft arrays. total ~36mb

[Ilya Tikhonovsky]

(In reply to comment #7)
> (From update of attachment 173268 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=173268&action=review
> 
> > Source/WebCore/dom/ActiveDOMObject.cpp:98
> > +    UNUSED_PARAM(info);
> 
> Please remove this.

done

> 
> > Source/WebCore/dom/ContextDestructionObserver.h:43
> > +    virtual void reportMemoryUsage(MemoryObjectInfo*) const;
> 
> We shouldn't add reportMemoryUsage to abstract interfaces as we don't control their implementations.

done

> 
> > Source/WebCore/dom/WebCoreMemoryInstrumentation.h:48
> > +    static MemoryObjectType Audio;
> 
> Should go into PlatformMemoryInstrumentation.h

done.

[Ilya Tikhonovsky]

Committed r134593: <http://trac.webkit.org/changeset/134593>

[Kentaro Hara]

It looks like this patch broke inspector-protocol/nmi-webaudio.html. I will mark it as FAIL. Please fix it soon.

[Simon Fraser (smfr)]

That test is also asserting in Mac debug builds:
http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK1%20(Tests)/r135081%20(2941)/inspector-protocol/nmi-webaudio-crash-log.txt