Summary: | [EFL][WK2] Add support for custom cursors | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||
Component: | WebKit EFL | Assignee: | Chris Dumez <cdumez> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | gyuyoung.kim, kenneth, laszlo.gombos, lucas.de.marchi, rakuco, ryuan.choi, tonikitoo, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Chris Dumez
2012-11-09 01:27:07 PST
Created attachment 173238 [details]
Patch
Comment on attachment 173238 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173238&action=review > Source/WebCore/platform/graphics/efl/ImageEfl.cpp:70 > +Evas_Object* BitmapImage::getEvasObject(Evas* evas) > +{ > + NativeImageCairo* image = nativeImageForCurrentFrame(); > + return image ? evasObjectFromCairoImageSurface(evas, image->surface()).leakRef() : 0; > +} In Qt this would be called toEvasObject as it does work and not just returns (In reply to comment #2) > (From update of attachment 173238 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=173238&action=review > > > Source/WebCore/platform/graphics/efl/ImageEfl.cpp:70 > > +Evas_Object* BitmapImage::getEvasObject(Evas* evas) > > +{ > > + NativeImageCairo* image = nativeImageForCurrentFrame(); > > + return image ? evasObjectFromCairoImageSurface(evas, image->surface()).leakRef() : 0; > > +} > > In Qt this would be called toEvasObject as it does work and not just returns I kept consistency with other ports: virtual NSImage* getNSImage() { return 0; } virtual CGImageRef getCGImageRef() { return 0; } virtual bool getHBITMAP(HBITMAP) { return false; } virtual GdkPixbuf* getGdkPixbuf() { return 0; } Comment on attachment 173238 [details] Patch Clearing flags on attachment: 173238 Committed r134041: <http://trac.webkit.org/changeset/134041> All reviewed patches have been landed. Closing bug. |