Bug 101696

Summary: Make assumptions about m_parentStyle consistent within StyleResolver::applyProperty()
Product: WebKit Reporter: Luke Macpherson <macpherson>
Component: New BugsAssignee: Luke Macpherson <macpherson>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, cmarcelo, kling, koivisto, macpherson, menard, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Luke Macpherson
Reported 2012-11-08 20:23:11 PST
Make assumptions about m_parentStyle consistent within StyleResolver::applyProperty()
Attachments
Patch (2.58 KB, patch)
2012-11-08 20:27 PST, Luke Macpherson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Luke Macpherson
Comment 1 2012-11-08 20:27:15 PST
Created attachment 173187 [details] Patch
Tony Chang
Comment 2 2012-11-13 10:07:02 PST
Comment on attachment 173187 [details] Patch This looks correct, but I'm curious about the other use of m_parentStyle in StyleResolver::applyProperty. In the CSSPropertyContent case, we use m_parentStyle. I wonder if that's safe?
Luke Macpherson
Comment 3 2012-11-15 15:57:02 PST
I see what you mean. It's hard to reason about the initialization state of StyleResolver right now to give a hard answer to that question.
WebKit Review Bot
Comment 4 2012-11-15 16:14:04 PST
Comment on attachment 173187 [details] Patch Clearing flags on attachment: 173187 Committed r134846: <http://trac.webkit.org/changeset/134846>
WebKit Review Bot
Comment 5 2012-11-15 16:14:08 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.