Bug 101675 – [TexMap] Initialize m_compositedNativeImagePtr in GraphicsLayerTextureMapper.

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Dongseong Hwang]

Fix a potential bug in GraphicsLayerTextureMapper. If the member's uninitialized
value equals image->nativeImageForCurrentFrame() by change, we can encounter
undefined behavior.

[Dongseong Hwang]

Created attachment 173160 [details]
Patch

[Noam Rosenthal]

Comment on attachment 173160 [details]
Patch

Any way to test this?

[Dongseong Hwang]

(In reply to comment #2)
> (From update of attachment 173160 [details])
> Any way to test this?

I think it is hard because m_compositedNativeImagePtr is initialized to random value.

m_compositedNativeImagePtr is used only in
if (newNativeImagePtr == m_compositedNativeImagePtr)
    return;

If we want to make a test, the test must have the ability to check the above code. Unfortunately, I can not imagine.

[WebKit Review Bot]

Comment on attachment 173160 [details]
Patch

Rejecting attachment 173160 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

Last 500 characters of output:
mit-queue/Source/WebKit/chromium/third_party/skia/src --revision 6360 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
47>At revision 6360.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/14790103

[Dongseong Hwang]

Created attachment 173391 [details]
Patch

[Dongseong Hwang]

Thanks for review! Could you r+ one more time? commit-queue failed flaky.

[WebKit Review Bot]

Comment on attachment 173391 [details]
Patch

Clearing flags on attachment: 173391

Committed r134140: <http://trac.webkit.org/changeset/134140>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.