Bug 101654
| Summary: | Node::removedFrom could be renamed | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Stephen Chenney <schenney> |
| Component: | DOM | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | darin, eric, esprehn, haraken, inferno, morrita, rniwa |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Stephen Chenney
Node::removedFrom is not called when a node is removed due to Document::removedLastRef. In that case, as an optimization, we just call the destructor (it is also rumored that this is the reason we do not issue onunload on frame destruction).
We need a better name for removedFrom, or some other mechanism, to remind implementors that anything they do to clean up pointers etc must be done in both the destructor and removedFrom.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Stephen Chenney
See http://trac.webkit.org/changeset/113852 as another example of a bug due to this behavior.
Abhishek Arya
and https://bugs.webkit.org/show_bug.cgi?id=101505