Bug 101646

Summary:

[BlackBerry] Disable cookies on file://

Product:

WebKit

Reporter:

otcheung

Component:

WebKit BlackBerry

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

mifenton, rwlbuis, tonikitoo, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

otcheung

Reported 2012-11-08 14:34:17 PST

Disabling cookies on file:// on browser app

Attachments
Patch (5.58 KB, patch) 2012-11-08 14:42 PST, otcheung	no flags	Details Formatted Diff Diff
Patch (5.58 KB, patch) 2012-11-08 14:47 PST, otcheung	no flags	Details Formatted Diff Diff
Patch (5.80 KB, patch) 2012-11-08 14:57 PST, otcheung	no flags	Details Formatted Diff Diff
Patch (5.90 KB, patch) 2012-11-08 15:08 PST, otcheung	no flags	Details Formatted Diff Diff
Patch (5.90 KB, patch) 2012-11-08 15:13 PST, otcheung	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

otcheung

Comment 1 2012-11-08 14:42:11 PST

Created attachment 173121 [details] Patch

otcheung

Comment 2 2012-11-08 14:47:41 PST

Created attachment 173123 [details] Patch

Rob Buis

Comment 3 2012-11-08 14:54:30 PST

Comment on attachment 173123 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173123&action=review Almost there. > Source/WebCore/platform/blackberry/CookieManager.cpp:129 > +static bool shouldIgnoreScheme(const String protocol) Use &. > Source/WebCore/platform/blackberry/CookieManager.cpp:243 > + // We only want to enable them if the webworks app enabled a flag for it (m_shouldDumpAllCookies) Periods at end of sentences.

otcheung

Comment 4 2012-11-08 14:57:52 PST

Created attachment 173127 [details] Patch

Rob Buis

Comment 5 2012-11-08 15:04:36 PST

Comment on attachment 173127 [details] Patch LGTM.

otcheung

Comment 6 2012-11-08 15:08:33 PST

Created attachment 173128 [details] Patch

otcheung

Comment 7 2012-11-08 15:13:16 PST

Created attachment 173131 [details] Patch