Summary: | MarkStackArray should use the BlockAllocator instead of the MarkStackSegmentAllocator | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Hahnenberg <mhahnenberg> | ||||||
Component: | JavaScriptCore | Assignee: | Mark Hahnenberg <mhahnenberg> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | gtk-ews, gustavo, webkit.review.bot, xan.lopez | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Mark Hahnenberg
2012-11-08 13:58:55 PST
Created attachment 173116 [details]
Patch
Comment on attachment 173116 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173116&action=review > Source/JavaScriptCore/heap/BlockAllocator.h:326 > + return m_weakRegionSet; Then can you rename m_weakRegionSet to something that reflects its dual purpose? Created attachment 173124 [details]
Patch
Comment on attachment 173124 [details] Patch Attachment 173124 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/14763806 Comment on attachment 173124 [details] Patch Rejecting attachment 173124 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ing file Source/JavaScriptCore/heap/MarkStackInlineMethods.h Hunk #1 FAILED at 31. Hunk #2 FAILED at 69. Hunk #3 FAILED at 79. Hunk #4 FAILED at 89. Hunk #5 FAILED at 105. 5 out of 5 hunks FAILED -- saving rejects to file Source/JavaScriptCore/heap/MarkStackInlineMethods.h.rej patching file Source/JavaScriptCore/heap/SlotVisitor.cpp Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Filip Pizlo']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/14778471 Committed r134080: <http://trac.webkit.org/changeset/134080> |