Bug 101624

Summary: 4.68MB below RenderStyle::filter() on Membuster3.
Product: WebKit Reporter: Andreas Kling <kling>
Component: Layout and RenderingAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, cmarcelo, eric, krit, macpherson, menard, simon.fraser, webkit-bug-importer, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Same patch, glitzier ChangeLog
none
How hard can it be? none

Andreas Kling
Reported 2012-11-08 10:27:24 PST
There's a const overload of RenderStyle::filter() that doesn't copy-on-write the inherited data, but this almost never gets picked since calls typically go through a RenderStyle*.
Attachments
Patch (3.11 KB, patch)
2012-11-08 10:35 PST, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Same patch, glitzier ChangeLog (954 bytes, patch)
2012-11-08 10:43 PST, Andreas Kling 		no flags
DetailsFormatted DiffDiff
How hard can it be? (3.11 KB, patch)
2012-11-08 10:45 PST, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2012-11-08 10:33:27 PST
<rdar://problem/12663822>
Andreas Kling
Comment 2 2012-11-08 10:35:50 PST
Created attachment 173069 [details] Patch
Andreas Kling
Comment 3 2012-11-08 10:42:21 PST
Actually, the total wasted memory is 4.68MB (additional cost from no longer sharing the StyleRareNonInheritedData.) More savings, yay! \o/
Andreas Kling
Comment 4 2012-11-08 10:43:36 PST
Created attachment 173070 [details] Same patch, glitzier ChangeLog
Andreas Kling
Comment 5 2012-11-08 10:45:54 PST
Created attachment 173071 [details] How hard can it be?
Dirk Schulze
Comment 6 2012-11-08 11:02:40 PST
(In reply to comment #3) > Actually, the total wasted memory is 4.68MB (additional cost from no longer sharing the StyleRareNonInheritedData.) > > More savings, yay! \o/ Awesome catch!
WebKit Review Bot
Comment 7 2012-11-08 11:38:19 PST
Comment on attachment 173071 [details] How hard can it be? Clearing flags on attachment: 173071 Committed r133926: <http://trac.webkit.org/changeset/133926>
WebKit Review Bot
Comment 8 2012-11-08 11:38:24 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.