Bug 101608

Summary: [BlackBerry] Rework the API to use document coordinates
Product: WebKit Reporter: Jakob Petsovits <jpetsovits>
Component: WebKit BlackBerryAssignee: Jakob Petsovits <jpetsovits>
Status: RESOLVED FIXED    
Severity: Normal CC: anilsson, eric.carlson, feature-media-reviews, manyoso, mifenton, rwlbuis, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Jakob Petsovits
Reported 2012-11-08 08:13:32 PST
Scrolling and zooming APIs used to operate on transformed coordinates, which is a bad idea: The UI thread might long have moved on to a different scale and scroll position so outdated pixel coordinates are of limited value. Moreover, more transformation calculations are needed than if we operate purely on document coordinates. With webkitThreadViewportAccessor() exposed, the caller has a choice between how to handle coordinates and the means to perform conversions with little effort and overhead if needed. Therefore, we should remove pixel coordinates from the public API. The patch below makes this change. Internally tracked as part of RIM PR 173292.
Attachments
Patch (64.33 KB, patch)
2012-11-08 08:26 PST, Jakob Petsovits 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jakob Petsovits
Comment 1 2012-11-08 08:26:21 PST
Created attachment 173049 [details] Patch
Adam Treat
Comment 2 2012-11-08 08:54:20 PST
Comment on attachment 173049 [details] Patch This is the way we are going so r+
WebKit Review Bot
Comment 3 2012-11-08 10:21:53 PST
Comment on attachment 173049 [details] Patch Clearing flags on attachment: 173049 Committed r133914: <http://trac.webkit.org/changeset/133914>
WebKit Review Bot
Comment 4 2012-11-08 10:21:56 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.