Bug 101570

Summary: [EFL] Add a method to the TextCheckerEnchant class to check whether any dictionary is loaded
Product: WebKit Reporter: Grzegorz Czajkowski <g.czajkowski>
Component: WebKit EFLAssignee: Grzegorz Czajkowski <g.czajkowski>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, gyuyoung.kim, laszlo.gombos, lucas.de.marchi, mario, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch
gustavo: review-
apply Gustavo's suggestions none

Grzegorz Czajkowski
Reported 2012-11-08 02:47:25 PST
Expose a new method to check whether a vector of loaded languages is empty. WK2-EFL needs it to set the default language (if the client didn't set any) when spelling setting is being enabled. This change allows to do not get vector of dictionaries to just check its size.
Attachments
proposed patch (6.21 KB, patch)
2012-11-08 02:49 PST, Grzegorz Czajkowski 		gustavo: review-
DetailsFormatted DiffDiff
apply Gustavo's suggestions (6.21 KB, patch)
2012-11-08 06:04 PST, Grzegorz Czajkowski 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Grzegorz Czajkowski
Comment 1 2012-11-08 02:49:50 PST
Created attachment 172972 [details] proposed patch
Gustavo Noronha (kov)
Comment 2 2012-11-08 05:41:23 PST
Comment on attachment 172972 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=172972&action=review Mostly a readability/hackability change, so I'll be nit-picky and say languagesLoaded sounds to me like it would return the languages that have been loaded. Also, I'd prefer maintaining the "dictionary" terminology, so perhaps hasDictionary? > Source/WebCore/ChangeLog:11 > + spelling setting is being enabled. This change allows to do not get > + vector of dictionaries to just check its size. This last sentence is a bit broken. How about "This change makes it more convenient to check whether the dictionaries vector is empty."?
Grzegorz Czajkowski
Comment 3 2012-11-08 06:04:38 PST
Created attachment 173027 [details] apply Gustavo's suggestions
WebKit Review Bot
Comment 4 2012-11-08 23:36:41 PST
Comment on attachment 173027 [details] apply Gustavo's suggestions Clearing flags on attachment: 173027 Committed r134021: <http://trac.webkit.org/changeset/134021>
WebKit Review Bot
Comment 5 2012-11-08 23:36:45 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.