Bug 101568

Summary: [BlackBerry] need to call closePopup at setValueAndClosePopup
Product: WebKit Reporter: Chris.Guan <logingx>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: mifenton, rwlbuis, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Chris.Guan 2012-11-08 02:33:54 PST 
When early return occurs, we need to call closePopup function.
Comment 1 Chris.Guan 2012-11-08 03:09:14 PST 
Created attachment 172981 [details]
Patch
Comment 2 Mike Fenton 2012-11-08 04:41:35 PST 
Comment on attachment 172981 [details]
Patch

Looks good to me, Rob?
Comment 3 Rob Buis 2012-11-08 07:31:27 PST 
Comment on attachment 172981 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172981&action=review

Code looks good but ChangeLog should be better.

> Source/WebKit/blackberry/ChangeLog:10
> +        Internally reviewed by Charles Wei.

Please also state PR and internal reviewer.
I think the description could be better, since in the PR it states there is a freeze/crash which I can't see in this description.
Comment 4 Chris.Guan 2012-11-08 17:48:52 PST 
Created attachment 173161 [details]
Patch
Comment 5 WebKit Review Bot 2012-11-08 20:16:00 PST 
Comment on attachment 173161 [details]
Patch

Clearing flags on attachment: 173161

Committed r133999: <http://trac.webkit.org/changeset/133999>
Comment 6 WebKit Review Bot 2012-11-08 20:16:03 PST 
All reviewed patches have been landed.  Closing bug.