Bug 101568

Summary: [BlackBerry] need to call closePopup at setValueAndClosePopup
Product: WebKit Reporter: Chris.Guan <logingx>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: mifenton, rwlbuis, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Chris.Guan
Reported 2012-11-08 02:33:54 PST
When early return occurs, we need to call closePopup function.
Attachments
Patch (1.83 KB, patch)
2012-11-08 03:09 PST, Chris.Guan 		no flags
DetailsFormatted DiffDiff
Patch (1.98 KB, patch)
2012-11-08 17:48 PST, Chris.Guan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris.Guan
Comment 1 2012-11-08 03:09:14 PST
Created attachment 172981 [details] Patch
Mike Fenton
Comment 2 2012-11-08 04:41:35 PST
Comment on attachment 172981 [details] Patch Looks good to me, Rob?
Rob Buis
Comment 3 2012-11-08 07:31:27 PST
Comment on attachment 172981 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172981&action=review Code looks good but ChangeLog should be better. > Source/WebKit/blackberry/ChangeLog:10 > + Internally reviewed by Charles Wei. Please also state PR and internal reviewer. I think the description could be better, since in the PR it states there is a freeze/crash which I can't see in this description.
Chris.Guan
Comment 4 2012-11-08 17:48:52 PST
Created attachment 173161 [details] Patch
WebKit Review Bot
Comment 5 2012-11-08 20:16:00 PST
Comment on attachment 173161 [details] Patch Clearing flags on attachment: 173161 Committed r133999: <http://trac.webkit.org/changeset/133999>
WebKit Review Bot
Comment 6 2012-11-08 20:16:03 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.