Add tests for month picker

• Component: Forms
• Status: RESOLVED FIXED

[Keishi Hattori]

Add tests for month picker

[Keishi Hattori]

Created attachment 173259 [details]
Patch

[Keishi Hattori]

Created attachment 173544 [details]
Patch

[Kent Tamura]

Comment on attachment 173544 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173544&action=review

> LayoutTests/platform/chromium/fast/forms/calendar-picker/month-picker-key-operations.html:80
> +    eventSender.keyDown('\n');
> +    shouldBeNull('document.getElementById("mock-page-popup")');

Unfortunately this doesn't work any more because popup close operation is now asynchronous.
http://trac.webkit.org/changeset/134180

> LayoutTests/platform/chromium/fast/forms/calendar-picker/month-picker-key-operations.html:102
> +    eventSender.keyDown('\x1B');
> +    shouldBeNull('document.getElementById("mock-page-popup")');

ditto.

> LayoutTests/platform/chromium/fast/forms/calendar-picker/month-picker-mouse-operations.html:44
> +    clickElement(popupWindow.document.querySelectorAll(".day:not(.week-column)")[6]);
> +    shouldBeNull('document.getElementById("mock-page-popup")');

Ditto.

> LayoutTests/platform/chromium/fast/forms/calendar-picker/month-picker-with-step.html:31
> +    // Close popup
> +    eventSender.keyDown('\x1B');
> +
> +    document.getElementById('month').min = "2011-05";
> +    document.getElementById('month').value = "2012-02";
> +    
> +    // Reopen popup
> +    openPicker(document.getElementById('month'), test2);

ditto.

[Keishi Hattori]

Created attachment 173569 [details]
Patch

[Kent Tamura]

Comment on attachment 173569 [details]
Patch

looks good

[WebKit Review Bot]

Comment on attachment 173569 [details]
Patch

Clearing flags on attachment: 173569

Committed r134209: <http://trac.webkit.org/changeset/134209>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.