| Summary: | Add tests for week picker | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Keishi Hattori <keishi> | ||||||||
| Component: | Forms | Assignee: | Keishi Hattori <keishi> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | dglazkov, tkent, webkit.review.bot | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 100938 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Keishi Hattori
2012-11-07 23:45:46 PST
Created attachment 173632 [details]
Patch
Comment on attachment 173632 [details] Patch Attachment 173632 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14804683 New failing tests: platform/chromium/fast/forms/calendar-picker/week-picker-key-operations.html platform/chromium/fast/forms/calendar-picker/week-picker-appearance.html platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step.html Comment on attachment 173632 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173632&action=review > LayoutTests/ChangeLog:11 > + * platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png: Added. nit: Don't you make the selection blue border rounded-corners? > LayoutTests/ChangeLog:22 > + Please update TextExpectations for pixel tests and the F4 difference of week-picker-key-operations.html. Comment on attachment 173632 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173632&action=review >> LayoutTests/ChangeLog:11 >> + * platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png: Added. > > nit: Don't you make the selection blue border rounded-corners? This is intensional. If we round the corners the white background shows through at each corner. Comment on attachment 173632 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173632&action=review >>> LayoutTests/ChangeLog:11 >>> + * platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png: Added. >> >> nit: Don't you make the selection blue border rounded-corners? > > This is intensional. If we round the corners the white background shows through at each corner. ok, I understand. Created attachment 173786 [details]
Patch
Comment on attachment 173786 [details] Patch Rejecting attachment 173786 [details] from commit-queue. New failing tests: platform/chromium/fast/forms/calendar-picker/week-picker-appearance.html platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step.html Full output: http://queues.webkit.org/results/14817497 Created attachment 173829 [details]
Patch
Comment on attachment 173829 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=173829&action=review > LayoutTests/platform/chromium/TestExpectations:4190 > +webkit.org/b/101561 platform/chromium/fast/forms/calendar-picker/week-picker-appearance.html [ ImageOnlyFailure Pass ] > +webkit.org/b/101561 platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step.html [ ImageOnlyFailure Pass ] > + CQ result was Missing. Regressions: Unexpected missing results (2) platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step.html [ Missing ] platform/chromium/fast/forms/calendar-picker/week-picker-appearance.html [ Missing ] Comment on attachment 173829 [details] Patch Rejecting attachment 173829 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: yle/checkers/python.py", line 31, in <module> from webkitpy.thirdparty.autoinstalled.pylint import lint File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/pylint/lint.py", line 31, in <module> from pylint.checkers import utils File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/pylint/checkers/__init__.py", line 44, in <module> from logilab.astng.utils import ASTWalker ImportError: No module named logilab.astng.utils Full output: http://queues.webkit.org/results/14822331 Comment on attachment 173829 [details] Patch Rejecting attachment 173829 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: yle/checkers/python.py", line 31, in <module> from webkitpy.thirdparty.autoinstalled.pylint import lint File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/pylint/lint.py", line 31, in <module> from pylint.checkers import utils File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/pylint/checkers/__init__.py", line 44, in <module> from logilab.astng.utils import ASTWalker ImportError: No module named logilab.astng.utils Full output: http://queues.webkit.org/results/14809826 Comment on attachment 173829 [details] Patch Clearing flags on attachment: 173829 Committed r134731: <http://trac.webkit.org/changeset/134731> All reviewed patches have been landed. Closing bug. |