Bug 101552

Summary: Add properties for week/month picker in DateTimeChooserImpl::writeDocument
Product: WebKit Reporter: Keishi Hattori <keishi>
Component: FormsAssignee: Keishi Hattori <keishi>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, fishd, jamesr, tkent, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 100938    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Keishi Hattori 2012-11-07 23:35:11 PST
Add properties for week/month picker in DateTimeChooserImpl::writeDocument
Comment 1 Keishi Hattori 2012-11-07 23:42:55 PST
Created attachment 172940 [details]
Patch
Comment 2 Kent Tamura 2012-11-07 23:55:05 PST
Comment on attachment 172940 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172940&action=review

> Source/WebKit/chromium/ChangeLog:8
> +        min/max for month picker should be months since epoch. todayLabel should be ThisWeek/ThisMonth for week/month pickers. And we need to add "mode" property.

How about "weekLabel"?

> Source/WebKit/chromium/src/DateTimeChooserImpl.cpp:100
> +        minDate.setMillisecondsSinceEpochForDate(m_parameters.minimum);
> +        maxDate.setMillisecondsSinceEpochForDate(m_parameters.maximum);

Are you sure passing yyyy-mm-dd for mode:week?
Comment 3 Keishi Hattori 2012-11-08 03:31:20 PST
Created attachment 172991 [details]
Patch
Comment 4 WebKit Review Bot 2012-11-08 03:34:52 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 5 Kent Tamura 2012-11-08 03:43:26 PST
Comment on attachment 172991 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172991&action=review

> Source/Platform/chromium/public/WebLocalizedString.h:105
> +        WeekNumberLabel,
>          WeekFormatTemplate,

should keep alphabetical order
Comment 6 Keishi Hattori 2012-11-08 04:05:07 PST
Created attachment 173002 [details]
Patch
Comment 7 WebKit Review Bot 2012-11-08 09:43:48 PST
Comment on attachment 173002 [details]
Patch

Clearing flags on attachment: 173002

Committed r133910: <http://trac.webkit.org/changeset/133910>
Comment 8 WebKit Review Bot 2012-11-08 09:43:52 PST
All reviewed patches have been landed.  Closing bug.