Bug 101546

Summary: Remove unnecessary save/restore in SVGTextRunRenderingContext
Product: WebKit Reporter: Philip Rogers <pdr>
Component: SVGAssignee: Philip Rogers <pdr>
Status: RESOLVED FIXED    
Severity: Normal CC: d-r, eric, fmalita, reed, schenney, webkit.review.bot, zimmermann
Priority: P2    
Version: 420+   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Philip Rogers
Reported 2012-11-07 22:27:58 PST
The Skia team noticed SVG overzealously saves and restores contexts. SVGTextRunRenderingContext has a particularly egregious case where we save/restore on every text run just for stroke thickness: http://trac.webkit.org/browser/trunk/Source/WebCore/rendering/svg/SVGTextRunRenderingContext.cpp?rev=133290#L145 Saves and restores are not free and we can pick up performance by avoiding them.
Attachments
Patch (2.47 KB, patch)
2012-11-07 22:33 PST, Philip Rogers 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philip Rogers
Comment 1 2012-11-07 22:33:52 PST
Created attachment 172934 [details] Patch
Mike Reed
Comment 2 2012-11-08 05:02:41 PST
works for me
WebKit Review Bot
Comment 3 2012-11-08 07:20:26 PST
Comment on attachment 172934 [details] Patch Clearing flags on attachment: 172934 Committed r133897: <http://trac.webkit.org/changeset/133897>
WebKit Review Bot
Comment 4 2012-11-08 07:20:29 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.