Bug 101514

Summary: Remove ScrollingCoordinatorMac::updateMainFrameScrollPositionAndScrollLayerPosition()
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, jamesr, simon.fraser, thorton, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Simon Fraser (smfr)
Reported 2012-11-07 14:57:24 PST
Remove ScrollingCoordinatorMac::updateMainFrameScrollPositionAndScrollLayerPosition()
Attachments
Patch (9.99 KB, patch)
2012-11-07 15:22 PST, Simon Fraser (smfr) 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2012-11-07 15:22:13 PST
Created attachment 172879 [details] Patch
Tim Horton
Comment 2 2012-11-07 15:24:55 PST
Comment on attachment 172879 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172879&action=review > Source/WebCore/page/scrolling/ScrollingCoordinator.cpp:219 > +void ScrollingCoordinator::updateMainFrameScrollPosition(const IntPoint& scrollPosition, bool programmaticScroll, bool setLayerPosition) More boolean arguments? :( > Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:266 > + scrollingTree()->updateMainFrameScrollPosition(scrollPosition, true /* setLayerPosition */); See, this is the path down which those lead :)
Tim Horton
Comment 3 2012-11-07 16:10:57 PST
Comment on attachment 172879 [details] Patch Fix the bools and all will be well?
Simon Fraser (smfr)
Comment 4 2012-11-10 21:21:59 PST
http://trac.webkit.org/changeset/134169
Note You need to log in before you can comment on or make changes to this bug.