Bug 101511

Summary: DFG constant folding and CFG simplification should be smart enough to know that if a logical op's operand is proven to have a non-masquerading structure then it always evaluates to true
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 101839    
Bug Blocks:    
Attachments:
Description Flags
the patch
oliver: review+
the patch
none
the patch ggaren: review+

Filip Pizlo
Reported 2012-11-07 14:25:33 PST
Patch forthcoming.
Attachments
the patch (19.55 KB, patch)
2012-11-07 14:31 PST, Filip Pizlo 		oliver: review+
DetailsFormatted DiffDiff
the patch (21.13 KB, patch)
2012-11-10 14:04 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (21.12 KB, patch)
2012-11-10 14:05 PST, Filip Pizlo 		ggaren: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2012-11-07 14:31:57 PST
Created attachment 172873 [details] the patch
Filip Pizlo
Comment 2 2012-11-08 16:16:35 PST
Landed in http://trac.webkit.org/changeset/133971
WebKit Review Bot
Comment 3 2012-11-10 07:03:31 PST
Re-opened since this is blocked by bug 101839
Filip Pizlo
Comment 4 2012-11-10 13:24:55 PST
Wow, that was a silly mistake. I need to exclude strings from the boolean optimizations, since a string can be false (!!"" == false).
Filip Pizlo
Comment 5 2012-11-10 14:04:34 PST
Created attachment 173471 [details] the patch
Filip Pizlo
Comment 6 2012-11-10 14:05:31 PST
Created attachment 173473 [details] the patch
Geoffrey Garen
Comment 7 2012-11-10 15:32:20 PST
Comment on attachment 173473 [details] the patch r=me
Filip Pizlo
Comment 8 2012-11-10 15:34:31 PST
Relanded in http://trac.webkit.org/changeset/134164
Note You need to log in before you can comment on or make changes to this bug.