Bug 101510

Summary: [BlackBerry] Verify touched element using the rootEditableElement
Product: WebKit Reporter: Nima Ghanavatian <nima.ghanavatian>
Component: WebKit BlackBerryAssignee: Nima Ghanavatian <nima.ghanavatian>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, mifenton, rwlbuis, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Nima Ghanavatian
Reported 2012-11-07 14:11:56 PST
When tapping on a misspelled word, look at the rootEditableElement to verify if it is the element under focus.
Attachments
Patch (5.85 KB, patch)
2012-11-07 14:18 PST, Nima Ghanavatian 		no flags
DetailsFormatted DiffDiff
Patch (5.83 KB, patch)
2012-11-07 15:57 PST, Nima Ghanavatian 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nima Ghanavatian
Comment 1 2012-11-07 14:18:10 PST
Created attachment 172870 [details] Patch
WebKit Review Bot
Comment 2 2012-11-07 14:19:47 PST
Attachment 172870 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/ChangeLog', u'Sou..." exit_code: 1 Source/WebKit/blackberry/WebKitSupport/TouchEventHandler.cpp:242: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Rob Buis
Comment 3 2012-11-07 14:25:36 PST
Comment on attachment 172870 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172870&action=review Some stuff to fix, have a look at the style problem too and that the patch applies generally (guess we need to watch the bots). > Source/WebKit/blackberry/WebKitSupport/FatFingers.h:170 > + WebCore::Node* parentNode; You only need this in the while loop. > Source/WebKit/blackberry/WebKitSupport/FatFingers.h:174 > + break; Can you use parentElement here as well? > Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:713 > + Element* parentElement; You only need this in the while loop.
Nima Ghanavatian
Comment 4 2012-11-07 15:57:48 PST
Created attachment 172886 [details] Patch
WebKit Review Bot
Comment 5 2012-11-07 16:00:53 PST
Attachment 172886 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/ChangeLog', u'Sou..." exit_code: 1 Source/WebKit/blackberry/WebKitSupport/TouchEventHandler.cpp:242: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Rob Buis
Comment 6 2012-11-07 16:10:35 PST
Comment on attachment 172886 [details] Patch LGTM.
WebKit Review Bot
Comment 7 2012-11-08 08:24:35 PST
Comment on attachment 172886 [details] Patch Clearing flags on attachment: 172886 Committed r133902: <http://trac.webkit.org/changeset/133902>
WebKit Review Bot
Comment 8 2012-11-08 08:24:39 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.