Bug 101485

Summary:

[Qt] DumpRenderTree does not honor the shouldDumpPixels boolean argument of dumpAsText

Product:

WebKit

Reporter:

Balazs Kelemen <kbalazs>

Component:

Tools / Tests

Assignee:

Balazs Kelemen <kbalazs>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ossy

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Balazs Kelemen 2012-11-07 10:24:46 PST

All other platforms support it.

Comment 1 Balazs Kelemen 2012-11-07 10:31:19 PST

Created attachment 172831 [details]
Patch

Comment 2 Csaba Osztrogonác 2012-11-07 10:45:10 PST

Comment on attachment 172831 [details]
Patch

Good catch, r=me.

Comment 3 Balazs Kelemen 2012-11-07 11:03:16 PST

Comment on attachment 172831 [details]
Patch

I'm not sure how it will affect tests, so I'm going to land it tomorrow.

Comment 4 Balazs Kelemen 2012-11-08 01:50:27 PST

Comment on attachment 172831 [details]
Patch

Clearing flags on attachment: 172831

Committed r133869: <http://trac.webkit.org/changeset/133869>

Comment 5 Balazs Kelemen 2012-11-08 01:50:31 PST

All reviewed patches have been landed.  Closing bug.