Bug 101485 - [Qt] DumpRenderTree does not honor the shouldDumpPixels boolean argument of dumpAsText
Summary: [Qt] DumpRenderTree does not honor the shouldDumpPixels boolean argument of d...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Balazs Kelemen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-07 10:24 PST by Balazs Kelemen
Modified: 2012-11-08 01:50 PST (History)
1 user (show)

See Also:


Attachments
Patch (4.26 KB, patch)
2012-11-07 10:31 PST, Balazs Kelemen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Balazs Kelemen 2012-11-07 10:24:46 PST
All other platforms support it.
Comment 1 Balazs Kelemen 2012-11-07 10:31:19 PST
Created attachment 172831 [details]
Patch
Comment 2 Csaba Osztrogonác 2012-11-07 10:45:10 PST
Comment on attachment 172831 [details]
Patch

Good catch, r=me.
Comment 3 Balazs Kelemen 2012-11-07 11:03:16 PST
Comment on attachment 172831 [details]
Patch

I'm not sure how it will affect tests, so I'm going to land it tomorrow.
Comment 4 Balazs Kelemen 2012-11-08 01:50:27 PST
Comment on attachment 172831 [details]
Patch

Clearing flags on attachment: 172831

Committed r133869: <http://trac.webkit.org/changeset/133869>
Comment 5 Balazs Kelemen 2012-11-08 01:50:31 PST
All reviewed patches have been landed.  Closing bug.