Bug 101474

Summary: [V8] WebKit sends unnecessary low memory notification when running memory benchmarks
Product: WebKit Reporter: Ulan Degenbaev <ulan>
Component: WebCore JavaScriptAssignee: Ulan Degenbaev <ulan>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, haraken, japhet, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Ulan Degenbaev
Reported 2012-11-07 07:51:24 PST
In the following benchmark, we get GC pause of about 15 seconds because of low memory notification that was sent from WebKit. http://people.mozilla.org/~wmccloskey/incremental-blog/example-pause.html In this case the low memory notification is unnecessary because all memory usage consists of V8 objects, not DOM objects. So in this case V8 can schedule GC itself more optimally.
Attachments
Patch (2.32 KB, patch)
2012-11-07 08:03 PST, Ulan Degenbaev
no flags
Patch (2.52 KB, patch)
2012-11-07 08:18 PST, Ulan Degenbaev
no flags
Patch (2.46 KB, patch)
2012-11-07 08:21 PST, Ulan Degenbaev
no flags
Ulan Degenbaev
Comment 1 2012-11-07 08:03:43 PST
Ulan Degenbaev
Comment 2 2012-11-07 08:18:57 PST
Kentaro Hara
Comment 3 2012-11-07 08:20:38 PST
Comment on attachment 172808 [details] Patch I discussed with ulan offline. LGTM.
Ulan Degenbaev
Comment 4 2012-11-07 08:21:51 PST
WebKit Review Bot
Comment 5 2012-11-07 09:12:44 PST
Comment on attachment 172811 [details] Patch Clearing flags on attachment: 172811 Committed r133765: <http://trac.webkit.org/changeset/133765>
WebKit Review Bot
Comment 6 2012-11-07 09:12:48 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.