Bug 101470

Summary: [V8] Main world should have one DOMDataStore
Product: WebKit Reporter: Dan Carney <dcarney>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, haraken, japhet, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 101617    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Dan Carney
Reported 2012-11-07 07:07:11 PST
[V8] Main world should have one DOMDataStore
Attachments
Patch (3.35 KB, patch)
2012-11-07 07:10 PST, Dan Carney 		no flags
DetailsFormatted DiffDiff
Patch (3.76 KB, patch)
2012-11-08 00:07 PST, Dan Carney 		no flags
DetailsFormatted DiffDiff
Patch (3.77 KB, patch)
2012-11-08 03:09 PST, Dan Carney 		no flags
DetailsFormatted DiffDiff
Patch (4.06 KB, patch)
2012-11-09 00:01 PST, Dan Carney 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Dan Carney
Comment 1 2012-11-07 07:10:44 PST
Created attachment 172794 [details] Patch
Kentaro Hara
Comment 2 2012-11-07 07:18:02 PST
Comment on attachment 172794 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172794&action=review You might also want to rename defaultStore to mainWorldStore. > Source/WebCore/bindings/v8/DOMDataStore.cpp:78 > + return context->world()->isolatedWorldDomDataStore(); Nit: I guess that WebKit is likely to use isolatedWorld*DOM*DataStore.
Adam Barth
Comment 3 2012-11-07 08:27:20 PST
Nice.
Dan Carney
Comment 4 2012-11-08 00:07:57 PST
Created attachment 172945 [details] Patch
WebKit Review Bot
Comment 5 2012-11-08 00:08:52 PST
Comment on attachment 172945 [details] Patch Rejecting attachment 172945 [details] from review queue. dcarney@google.com does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights.
Kentaro Hara
Comment 6 2012-11-08 00:10:30 PST
Comment on attachment 172945 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172945&action=review Looks strange. I'll r+ and cq+ it again. > Source/WebCore/bindings/v8/DOMDataStore.cpp:57 > + DEFINE_STATIC_LOCAL(DOMDataStore, mainWorldStore, (MainWorld)); Nit: As you are naming isolatedWorldDOMDataStore(), this could be mainWorldDOMDataStore?
Dan Carney
Comment 7 2012-11-08 03:09:42 PST
Created attachment 172982 [details] Patch
Kentaro Hara
Comment 8 2012-11-08 03:10:08 PST
Comment on attachment 172982 [details] Patch thanks!
Dan Carney
Comment 9 2012-11-08 03:10:17 PST
Comment on attachment 172945 [details] Patch fixed the nit
WebKit Review Bot
Comment 10 2012-11-08 06:24:12 PST
Comment on attachment 172982 [details] Patch Clearing flags on attachment: 172982 Committed r133892: <http://trac.webkit.org/changeset/133892>
WebKit Review Bot
Comment 11 2012-11-08 06:24:15 PST
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 12 2012-11-08 09:31:55 PST
Re-opened since this is blocked by bug 101617
Dan Carney
Comment 13 2012-11-09 00:01:13 PST
Created attachment 173218 [details] Patch
WebKit Review Bot
Comment 14 2012-11-09 01:11:41 PST
Comment on attachment 173218 [details] Patch Clearing flags on attachment: 173218 Committed r134029: <http://trac.webkit.org/changeset/134029>
WebKit Review Bot
Comment 15 2012-11-09 01:11:45 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.