Bug 101617 – REGRESSION(r133892): Compile failures on mac, android, linux (Requested by jsbell|gardener on #webkit).

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[WebKit Review Bot]

http://trac.webkit.org/changeset/133892 broke the build:
Compile failures on mac, android, linux (Requested by jsbell|gardener on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear

[WebKit Review Bot]

Created attachment 173057 [details]
ROLLOUT of r133892

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.

[Joshua Bell]

First instance of the failure:

http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28dbg%29/builds/1328
http://build.chromium.org/p/chromium.webkit/builders/Android%20Builder%20%28dbg%29/builds/3533
http://build.chromium.org/p/chromium.webkit/builders/Mac%20Builder%20%28dbg%29/builds/16362

Typical errors from the build logs:

In file included from ../bindings/v8/ScriptState.h:34:
../bindings/v8/DOMWrapperWorld.h:83:16:error: member function 'isIsolatedWorld' not viable: 'this' argument has type 'const WebCore::DOMWrapperWorld', but function is not marked const
        ASSERT(isIsolatedWorld());

[Joshua Bell]

Comment on attachment 173057 [details]
ROLLOUT of r133892

Clearing flags on attachment: 173057

Committed r133909: <http://trac.webkit.org/changeset/133909>

[Joshua Bell]

All reviewed patches have been landed.  Closing bug.