Bug 101440

Summary: [Chromium] Arabic digits should appear left-to-right
Product: WebKit Reporter: Kenichi Ishibashi <bashi>
Component: PlatformAssignee: Kenichi Ishibashi <bashi>
Status: RESOLVED FIXED    
Severity: Normal CC: behdad, d-r, glenn, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
testcase
none
Patch
none
Patch for landing none

Description Kenichi Ishibashi 2012-11-07 01:47:00 PST 
Created attachment 172739 [details]
testcase

Original report: http://code.google.com/p/chromium/issues/detail?id=158969
Test case attached (from the original report).

Arabic-Indic digits (U+06f0-U+06f9) should appear in increasing order from left to right.
HarfBuzzShaper renders these digits right to left in increasing order.
Comment 1 Kenichi Ishibashi 2012-11-07 02:00:44 PST 
Created attachment 172741 [details]
Patch
Comment 2 Kenichi Ishibashi 2012-11-07 02:01:35 PST 
Hi Tony,

Could you take a look?
Comment 3 Tony Chang 2012-11-08 12:31:41 PST 
Comment on attachment 172741 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172741&action=review

> Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:235
> +    // HarfBuzz when we are calculating widths (except for directionalOverride() is set).

"except when directionOverride() is set" reads better in English.
Comment 4 Kenichi Ishibashi 2012-11-08 17:12:50 PST 
Created attachment 173155 [details]
Patch for landing
Comment 5 Kenichi Ishibashi 2012-11-08 17:13:26 PST 
Comment on attachment 172741 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172741&action=review

Thank you for review!

>> Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:235
>> +    // HarfBuzz when we are calculating widths (except for directionalOverride() is set).
> 
> "except when directionOverride() is set" reads better in English.

Done.
Comment 6 WebKit Review Bot 2012-11-08 17:34:47 PST 
Comment on attachment 173155 [details]
Patch for landing

Clearing flags on attachment: 173155

Committed r133983: <http://trac.webkit.org/changeset/133983>
Comment 7 WebKit Review Bot 2012-11-08 17:34:51 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Behdad Esfahbod 2012-11-19 07:58:57 PST 
Humm.  In general webkit must always pass direction down to HarfBuzz.  It would be wrong to rely on autodetection in HarfBuzz since Webkit would have its own idea of the run direction.