Bug 101440

Summary: [Chromium] Arabic digits should appear left-to-right
Product: WebKit Reporter: Kenichi Ishibashi <bashi>
Component: PlatformAssignee: Kenichi Ishibashi <bashi>
Status: RESOLVED FIXED    
Severity: Normal CC: behdad, d-r, glenn, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
testcase
none
Patch
none
Patch for landing none

Kenichi Ishibashi
Reported 2012-11-07 01:47:00 PST
Created attachment 172739 [details] testcase Original report: http://code.google.com/p/chromium/issues/detail?id=158969 Test case attached (from the original report). Arabic-Indic digits (U+06f0-U+06f9) should appear in increasing order from left to right. HarfBuzzShaper renders these digits right to left in increasing order.
Attachments
testcase (174 bytes, text/html)
2012-11-07 01:47 PST, Kenichi Ishibashi 		no flags
Details
Patch (10.01 KB, patch)
2012-11-07 02:00 PST, Kenichi Ishibashi 		no flags
DetailsFormatted DiffDiff
Patch for landing (10.01 KB, patch)
2012-11-08 17:12 PST, Kenichi Ishibashi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kenichi Ishibashi
Comment 1 2012-11-07 02:00:44 PST
Created attachment 172741 [details] Patch
Kenichi Ishibashi
Comment 2 2012-11-07 02:01:35 PST
Hi Tony, Could you take a look?
Tony Chang
Comment 3 2012-11-08 12:31:41 PST
Comment on attachment 172741 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172741&action=review > Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:235 > + // HarfBuzz when we are calculating widths (except for directionalOverride() is set). "except when directionOverride() is set" reads better in English.
Kenichi Ishibashi
Comment 4 2012-11-08 17:12:50 PST
Created attachment 173155 [details] Patch for landing
Kenichi Ishibashi
Comment 5 2012-11-08 17:13:26 PST
Comment on attachment 172741 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172741&action=review Thank you for review! >> Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:235 >> + // HarfBuzz when we are calculating widths (except for directionalOverride() is set). > > "except when directionOverride() is set" reads better in English. Done.
WebKit Review Bot
Comment 6 2012-11-08 17:34:47 PST
Comment on attachment 173155 [details] Patch for landing Clearing flags on attachment: 173155 Committed r133983: <http://trac.webkit.org/changeset/133983>
WebKit Review Bot
Comment 7 2012-11-08 17:34:51 PST
All reviewed patches have been landed. Closing bug.
Behdad Esfahbod
Comment 8 2012-11-19 07:58:57 PST
Humm. In general webkit must always pass direction down to HarfBuzz. It would be wrong to rely on autodetection in HarfBuzz since Webkit would have its own idea of the run direction.
Note You need to log in before you can comment on or make changes to this bug.