Bug 101435

Summary: Seam occurred between pieces of ShadowBlur on floating point zoom
Product: WebKit Reporter: KyungTae Kim <ktf.kim>
Component: Layout and RenderingAssignee: KyungTae Kim <ktf.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, leviw, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

KyungTae Kim
Reported 2012-11-07 00:33:18 PST
Issue> When paint Shadow that doesn't have blurred edge on floating point zoom, pixel seem occurred between pieces of the ShadowBlur because of unaligned clip rect. Solution> Enlarge the clipping area 1 pixel so that the fill does not bleed (due to antialiasing) even if the unaligned clip rect occurred
Attachments
Patch (1.87 KB, patch)
2012-11-07 01:26 PST, KyungTae Kim 		no flags
DetailsFormatted DiffDiff
Patch (1.93 KB, patch)
2012-11-07 17:52 PST, KyungTae Kim 		no flags
DetailsFormatted DiffDiff
Patch (1.93 KB, patch)
2012-11-07 17:56 PST, KyungTae Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
KyungTae Kim
Comment 1 2012-11-07 01:26:54 PST
Created attachment 172736 [details] Patch
Simon Fraser (smfr)
Comment 2 2012-11-07 16:27:41 PST
Comment on attachment 172736 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172736&action=review > Source/WebCore/ChangeLog:3 > + Seem occurred between pieces of ShadowBlur on floating point zoom Seam. We often refer to these as "pixel cracks". > Source/WebCore/ChangeLog:9 > + pixel seem occurred between pieces of the ShadowBlur because of unaligned clip rect. seam
KyungTae Kim
Comment 3 2012-11-07 17:52:42 PST
Created attachment 172903 [details] Patch
Simon Fraser (smfr)
Comment 4 2012-11-07 17:54:27 PST
Comment on attachment 172903 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172903&action=review > Source/WebCore/ChangeLog:9 > + pixel seam(pixel cracks) occurred between pieces of the ShadowBlur because of unaligned clip rect. space before (
KyungTae Kim
Comment 5 2012-11-07 17:56:20 PST
Created attachment 172904 [details] Patch
WebKit Review Bot
Comment 6 2012-11-07 19:03:35 PST
Comment on attachment 172904 [details] Patch Clearing flags on attachment: 172904 Committed r133836: <http://trac.webkit.org/changeset/133836>
WebKit Review Bot
Comment 7 2012-11-07 19:03:40 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.