Bug 101408

Summary:

[Chromium] platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html is flaky

Product:

WebKit

Reporter:

Joshua Bell <jsbell>

Component:

Forms

Assignee:

Keishi Hattori <keishi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, adamk, haraken, keishi, morrita, tkent, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Fix calendar-picker-key-operations.html on Mac	none
Patch for landing	none

Joshua Bell

Reported 2012-11-06 16:26:06 PST

Test: platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html Flakiness dashboard: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=platform%2Fchromium%2Ffast%2Fforms%2Fcalendar-picker%2Fcalendar-picker-key-operations.html Seems to fail on each platform bot around once a day - bad test? Failure is: -PASS testToday() || testToday() is true +FAIL testToday() || testToday() should be true. Was false. Code is: // Test twice in case midnight. shouldBeTrue('testToday() || testToday()'); That seems sketchy.

Attachments
Patch (1.78 KB, patch) 2012-11-07 05:52 PST, Keishi Hattori	no flags	Details Formatted Diff Diff
Fix calendar-picker-key-operations.html on Mac (2.58 KB, patch) 2013-01-20 23:44 PST, Kent Tamura	no flags	Details Formatted Diff Diff
Patch for landing (3.84 KB, patch) 2013-01-22 19:58 PST, Kent Tamura	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Joshua Bell

Comment 1 2012-11-06 16:30:31 PST

Marked flaky in http://trac.webkit.org/changeset/133691

Keishi Hattori

Comment 2 2012-11-07 05:52:31 PST

Created attachment 172778 [details] Patch

Kent Tamura

Comment 3 2012-11-07 17:21:58 PST

Comment on attachment 172778 [details] Patch ok

WebKit Review Bot

Comment 4 2012-11-07 17:42:01 PST

Comment on attachment 172778 [details] Patch Clearing flags on attachment: 172778 Committed r133831: <http://trac.webkit.org/changeset/133831>

WebKit Review Bot

Comment 5 2012-11-07 17:42:04 PST

All reviewed patches have been landed. Closing bug.

Adam Klein

Comment 6 2012-12-11 16:04:40 PST

This test now always fails on Mac: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=platform%2Fchromium%2Ffast%2Fforms%2Fcalendar-picker%2Fcalendar-picker-key-operations.html Moreover, the "mouse" operations test next to it is flaky: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=platform%2Fchromium%2Ffast%2Fforms%2Fcalendar-picker%2Fcalendar-picker-mouse-operations.html

Kent Tamura

Comment 7 2013-01-20 23:44:15 PST

Created attachment 183719 [details] Fix calendar-picker-key-operations.html on Mac

Kentaro Hara

Comment 8 2013-01-20 23:47:26 PST

Comment on attachment 183719 [details] Fix calendar-picker-key-operations.html on Mac Looks OK

Kent Tamura

Comment 9 2013-01-20 23:53:03 PST

(In reply to comment #6) > Moreover, the "mouse" operations test next to it is flaky: > > http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=platform%2Fchromium%2Ffast%2Fforms%2Fcalendar-picker%2Fcalendar-picker-mouse-operations.html It looks unrelated to this bug. I filed Bug 107423, and will update TestExpectations.

WebKit Review Bot

Comment 10 2013-01-21 00:36:37 PST

Comment on attachment 183719 [details] Fix calendar-picker-key-operations.html on Mac Rejecting attachment 183719 [details] from commit-queue. New failing tests: platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html Full output: http://queues.webkit.org/results/16011208

Kent Tamura

Comment 11 2013-01-22 19:52:25 PST

(In reply to comment #10) > New failing tests: > platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html > Full output: http://queues.webkit.org/results/16011208 I found LayoutTests/platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations-expected.txt contained a FAIL line. This patch will fix it too. > PASS focusedElement() is ".clear-button[value=<<CalendarClear>>]" > FAIL document.getElementById("mock-page-popup") should be null. Was [object HTMLIFrameElement]. > PASS document.getElementById("date").value is "1999-12-26"

Kent Tamura

Comment 12 2013-01-22 19:58:06 PST

Created attachment 184112 [details] Patch for landing

WebKit Review Bot

Comment 13 2013-01-22 20:22:33 PST

Comment on attachment 184112 [details] Patch for landing Clearing flags on attachment: 184112 Committed r140501: <http://trac.webkit.org/changeset/140501>

WebKit Review Bot

Comment 14 2013-01-22 20:22:37 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.